Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a media from this page is already used for the blur, will it early return or animate again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is currently any case that there is a double call since it's called within
switchTo
andonUIStateUpdate_
.If the window is scaled and still on the same page, It will draw the blur again but will not animate since it's the first update of the instance.
We remove the blur from the dom at the start of every
onUIStateUpdate_
:https://github.com/ampproject/amphtml/blob/main/extensions/amp-story/1.0/amp-story.js#L1824-L1825
We currently don't check or cache page media within
backgroundBlur
but that might be a good thing to do if want to be sure to prevent duplicate calls.