Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z_index.md #35306

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Fix z_index.md #35306

merged 1 commit into from
Jul 20, 2021

Conversation

caroqliu
Copy link
Contributor

@samouri
Copy link
Member

samouri commented Jul 20, 2021

This change is much larger than I'd expect. Is it possible the dependency used to do the formatting has been updated?

@caroqliu
Copy link
Contributor Author

Merging for now to unblock other PRs, but @alanorozco can you advise? Not sure how this file gets out of sync, and not seeing any recent package updates in our commit history.

@caroqliu caroqliu merged commit da9e43f into ampproject:main Jul 20, 2021
@danielrozenberg
Copy link
Member

@alanorozco and I discovered recently that amp get-zindex had a race-condition issue that only started manifesting when we switched our CircleCI jobs from VMs to Docker containers (which have less predictable CPU cycles, that can go up and down during the job execution)

Alan fixed this task, so it's possible that the results before were incorrect

@alanorozco
Copy link
Member

What @danielrozenberg said seems like the most likely explanation.

This change is much larger than I'd expect. Is it possible the dependency used to do the formatting has been updated?

The formatter did not change, but some entries were out of date. Markdown table columns are formatted to match the widest cell, so when that changes all rows are re-formatted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants