-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadbandy AMP Integration #36010
Broadbandy AMP Integration #36010
Conversation
Hey @rsimha! These files were changed:
Hey @erwinmombay! These files were changed:
Hey @jridgewell! These files were changed:
Hey @alanorozco! These files were changed:
Hey @rcebulko! These files were changed:
Hey @estherkim! These files were changed:
Hey @danielrozenberg! These files were changed:
Hey @jeffkaufman! These files were changed:
Hey @gmajoulet, @newmuis! These files were changed:
Hey @processprocess! These files were changed:
Hey @westonruter, @ediamin! These files were changed:
Hey @ampproject/wg-performance! These files were changed:
Hey @ampproject/wg-caching! These files were changed:
|
* update compilerOptions.paths to handle barrel files (index.js) in VSCode * update includes/excludes allowlist/blocklist src files
* Bento Selector Option: Give props via JSX * Remove extraneous event handlers
* applyAmpConfig: also update sourcemaps * no stone unturned: AMP_CONFIG should be part of the wrapper * update comments * update comment + fix bug * another bugfix * allow newline between ; and AMP_CONFIG * retain logs for dist|build * smol clean * Update build-system/tasks/prepend-global/index.js Co-authored-by: Raghu Simha <rsimha@amp.dev> * Update build-system/tasks/prepend-global/index.js Co-authored-by: Raghu Simha <rsimha@amp.dev> * target --> filename Co-authored-by: Raghu Simha <rsimha@amp.dev>
…ect#35317) * Since we are not using the data, lets remove it * Remove all isIE checks and polyfills only used by IE * Remove URL changes * Integration tests were looking for IE specifics * remove transparent img, and ie tests * Skip all tests on IE, this functionality will be removed by the infra team following success * try using user agent directy in test configuration * Fix * Feedback on describe tests not needing configuration now * Remove unused files again * Fix build before main is repaired
* Merged the VerizonMedia ad component into the yahoo component * Fixed documentation formatting issues.
* Catch for promise. * Update comment. * Send e.
…ject#35786) * Add position to attachment-content wrapper. * whitespace
* Wrap all play calls in catch handler * Introduce playIgnoringError * Fix type * Fix undefined return case
…ent unintentionally (ampproject#35779)
* add policy attributes * add owners * update files for Owners. * Revert file * added GAM implementation * removed policy attribute * removed policy attribute description * changed attribute name and corrected indentation * indentation corrected * new line added at last
This is to prevent new stable releases of Chrome from causing test failures. Eg, the Chrome 93 release caused several tests failures that made `main` red until the tests were skipped. This delayed a cherry-pick we're working on, since the new release (on on top of old code) also picked up Chrome 93. This should be updated regularly, hopefully with a chance to test Chrome releases during the Beta period so we can proactively fix issues. Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev>
* Add try catch * Changed PR number to match PR
HI, i see the we are still missing the approval, anything we can do from our side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! just one nit.
Hi there,
We'd like to integrate our Ad-Server with AMP. We've contributed to AMP as per documentation. Please check & approve.
Thanks in advance!
Tijl Verbert