Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadbandy AMP Integration #36010

Merged
merged 135 commits into from
Sep 16, 2021
Merged
Show file tree
Hide file tree
Changes from 128 commits
Commits
Show all changes
135 commits
Select commit Hold shift + click to select a range
844255d
Broadbandy ad service implementation
Sep 1, 2021
770841a
Merge branch 'main' into broadbandy
tverbert Sep 1, 2021
392354c
Revert serve port
Sep 8, 2021
615747b
Merge branch 'broadbandy' of github.com:BroadBandyDev/amphtml into br…
Sep 8, 2021
2d96f72
Merge branch 'main' into broadbandy
tverbert Sep 8, 2021
9d29dfe
Merge branch 'main' into broadbandy
tverbert Sep 9, 2021
2f82226
Broadbandy ad service implementation
DevMahix Sep 1, 2021
50c89ba
Revert serve port
DevMahix Sep 8, 2021
2b796bb
🏗 Misc tsconfig updates (#35787)
kvchari Aug 25, 2021
834a442
♻️ Bento Selector: Simplify logic (#35758)
caroqliu Aug 25, 2021
37df242
esbuild-exp fix define_experiment_constant (#35800)
samouri Aug 25, 2021
3113c43
SwG Release 0.1.22.181 (#35808)
mmmicedcoffee Aug 25, 2021
1b3cd60
Improve AMP_CONFIG handling during build (#35773)
samouri Aug 25, 2021
0192b92
hide placeholder when tweet is succesfully loaded (#35788)
kvchari Aug 25, 2021
cd98560
🚮 Remove IE Support via Polyfills and Conditional Statements (#35317)
kristoferbaxter Aug 25, 2021
d87e392
🏗🚮 Remove all IE11 infrastructure code paths (#35341)
rsimha Aug 26, 2021
5431330
Revert "Improve AMP_CONFIG handling during build (#35773)" (#35819)
samouri Aug 26, 2021
8bc8a3d
♻️ Verizon media yahoo components merge (#35797)
oath-jac Aug 26, 2021
67199a9
🐛 [Amp story] Catch ScreenOrientation.lock promise (#35767)
processprocess Aug 26, 2021
806c42f
🐛[Amp story] Add position scope to attachment-content wrapper (#35786)
processprocess Aug 26, 2021
1e69fe2
remove re-export and update MessageType imports (#35817)
kvchari Aug 26, 2021
db1fc48
Wrap all play calls in catch handler (#35811)
jridgewell Aug 26, 2021
cb91def
[amp-iframe] Wrap iframe in shadow DOM and ContainWrapper (#35774)
dmanek Aug 26, 2021
2e5f944
build-system: fix infinite loop caused by watching css in npm dist fo…
samouri Aug 26, 2021
42f2e18
Change amp-sticky-ad-to-amp-ad name to avoid trigging the old experim…
powerivq Aug 26, 2021
26f580b
amp GAM support added (#35782)
ColombiaOnline Aug 26, 2021
b3631b8
🏗 Simplify release tracker issue template (#35825)
estherkim Aug 26, 2021
c06b9ca
fix some types (#35832)
rileyajones Aug 26, 2021
8366697
ie deprecation/bugfix: remove isIe check (#35833)
samouri Aug 26, 2021
c6bc1b4
Disable EsbuildCompilation experiment. (#35814)
samouri Aug 26, 2021
86cffbb
✨ Action `toggleChecked()` (#35795)
anrghg Aug 27, 2021
284e854
Add TrafficStars ad network support (#35836)
ishaba Aug 27, 2021
3c1efbe
📦 Update dependency esbuild to v0.12.11 (#35058)
renovate[bot] Aug 27, 2021
41a3179
📦 Update dependency prettier to v2.3.2 (#35059)
renovate[bot] Aug 27, 2021
452f379
📦 Update dependency esbuild to v0.12.24 (#35840)
renovate[bot] Aug 27, 2021
3b1c41b
✨ `amp-date-display`: Support `timeZoneName` and `timeZoneNameShort` …
alanorozco Aug 27, 2021
b9dbc5e
📦 Update dependency prismjs to 1.24.0 [SECURITY] (#35082)
renovate[bot] Aug 27, 2021
50a1141
📦 Update dependency path-parse to 1.0.7 [SECURITY] (#35600)
renovate[bot] Aug 27, 2021
eef881a
📦 Update linting devDependencies (#35842)
renovate[bot] Aug 27, 2021
590e0d0
📦 Update subpackage devDependencies (#35035)
renovate[bot] Aug 27, 2021
bba49bb
📦 Update dependency eslint-plugin-jsdoc to v36 (#35392)
renovate[bot] Aug 27, 2021
42bebc0
📦 Update core devDependencies (#34748)
renovate[bot] Aug 27, 2021
c5bf4f8
📦 Update validator devDependencies (#35841)
renovate[bot] Aug 27, 2021
106f834
📦 Update build-system devDependencies (major) (#35377)
renovate[bot] Aug 27, 2021
4b0ee3b
📦 Update dependency jszip to 3.7.0 [SECURITY] (#35599)
renovate[bot] Aug 27, 2021
177d7a9
📦 Update build-system devDependencies (#34993)
renovate[bot] Aug 27, 2021
b1dc8f2
Remove amp-unresolved when extension downloads in R1 (#35845)
jridgewell Aug 28, 2021
91a26a9
🏗 Ensure every babel invocation has a name (#35851)
jridgewell Aug 30, 2021
598f5ef
🏗 Replace `globby` with `fast-glob` (#35846)
rsimha Aug 30, 2021
7708693
Remove IE11 support from supported browsers (#35865)
kristoferbaxter Aug 30, 2021
b1c6fb8
mode: collapse definitions of localDev and test (#35823)
samouri Aug 31, 2021
dcc10c3
Remove getIntersectionChangeElementLayoutBox from amp-iframe. (#35860)
samouri Aug 31, 2021
ac0dac3
Find sizer and apply slot before `layoutCallback` (#35784)
caroqliu Aug 31, 2021
0446fbc
📖 `bento-twitter` documentation (#35847)
caroqliu Aug 31, 2021
3fd5e9f
🖍 Fix displaying hero images over blurry image placeholder (#35759)
jridgewell Aug 31, 2021
e37be73
🐛 [Amp story page attachment] Propagate title attribute to draggable …
processprocess Aug 31, 2021
8bbd499
Validator rollup (#35882)
MichaelRybak Aug 31, 2021
aee3c7d
Remove "for the specified Twitter id" (#35887)
caroqliu Aug 31, 2021
7bb6850
Sync for validator cpp engine and cpp htmlparser (#35885)
MichaelRybak Aug 31, 2021
545e499
Make `compiler.js` runnable within a node.js environment (#35849)
samouri Aug 31, 2021
14b6fac
🐛[`amp-tiktok`] Fix CLS bug. (#35850)
rbeckthomas Aug 31, 2021
c2d6efd
♻️ Remove use of `.find` (#35884)
alanorozco Aug 31, 2021
8de8bd5
📦 Update build-system devDependencies (#35856)
renovate[bot] Aug 31, 2021
62c320e
📦 Update dependency eslint-plugin-react to v7.25.1 (#35858)
renovate[bot] Aug 31, 2021
32034bf
Skip new test failures after Chrome93 release (#35900)
samouri Sep 1, 2021
261e046
🐛 Use `/register` for Storybook addons (#35890)
alanorozco Sep 1, 2021
9208f2c
⏮ Rollback `timeZoneName` changes (#35895)
alanorozco Sep 1, 2021
79029ba
Fix child identifiers in Doubleclick SRA IUs. (#35891)
zombifier Sep 1, 2021
8d32246
🏗 Cut a new nightly branch using CircleCI's scheduled jobs (dry run) …
danielrozenberg Sep 1, 2021
5c140f8
RTC vendors: add ConsentMetadata to Prebid Server (#33899)
bretg Sep 1, 2021
6a261a9
Revert "⏮ Rollback `timeZoneName` changes (#35895)" (#35911)
alanorozco Sep 1, 2021
8e2069a
🏗 Alias `amp-*.js` binaries as `bento-*.js` (#35880)
alanorozco Sep 1, 2021
cf6ee9f
SwG Release 0.1.22.182 (#35919)
ChrisAntaki Sep 1, 2021
34ec234
Revert "mode: collapse definitions of localDev and test (#35823)" (#3…
samouri Sep 1, 2021
a0e8a49
♻️ [Story performance] Simplify templates CSS by using attr instead o…
mszylkowski Sep 1, 2021
79e9357
Added CTA Migration page-outlink experiment (#35867)
jshamble Sep 1, 2021
c9e0b7f
🐛 Toggle placeholders/fallbacks properly on Bento components (#35821)
kvchari Sep 1, 2021
89b4b70
Move nightly branch cut job from CircleCI to GitHub Actions (#35909)
danielrozenberg Sep 2, 2021
04b943e
🐛 [amp-video-docking] Fix issue hiding docked player during scroll on…
klipstein Sep 2, 2021
b6a75cd
Skip flaky test (#35926)
alanorozco Sep 2, 2021
7d76038
♻️ Use Storybook `args` (first round) (#35915)
alanorozco Sep 2, 2021
8a05b2f
🐛 [Amp story page outlink] Default outlink color and warning (#35866)
processprocess Sep 2, 2021
1edb48d
🐛 [Amp story] Prevent pointer events on images (#35929)
processprocess Sep 2, 2021
db9180f
cl/394490119 Fix a bug where the CSS parser was not correctly account…
Sep 2, 2021
03e1a0f
🏗 Visual diff updates and fixes (#35942)
danielrozenberg Sep 3, 2021
5b6543f
Bento Carousel: Restore default `rtl` values (#35924)
caroqliu Sep 3, 2021
766cff6
🐛 [Attachment Forms] Remove the soft keyboard from view when the page…
coreymasanto Sep 3, 2021
4c87627
Rename `BaseCarousel` as `BentoBaseCarousel` (#35935)
dmanek Sep 3, 2021
bf861e9
Rename `Twitter` to `BentoTwitter` (#35933)
dmanek Sep 3, 2021
a95dc4a
📖 Update Storybook documentation in `testing.md` (#35944)
alanorozco Sep 3, 2021
541cd5d
📖 [Story videos] Add video documentation for Google cache (#35609)
mszylkowski Sep 3, 2021
db1d123
Update release-tagger.yml (#35946)
estherkim Sep 3, 2021
c45ff00
Add TrafficStars ad network integration (#35922)
ishaba Sep 3, 2021
536be4c
Sync for validator cpp engine and cpp htmlparser (#35952)
Sep 3, 2021
8f30d44
✨ Ssp params extended (#35957)
PetrBlaha Sep 7, 2021
7d0285d
refactor(amp-accordion): (#35864)
kvchari Sep 7, 2021
73d95a5
* rename DateDisplay -> BentoDateDisplay (#35875)
kvchari Sep 7, 2021
4712acd
🐛 Followup fix from BaseCarousel → BentoBaseCarousel rename (#35968)
danielrozenberg Sep 7, 2021
194bdcd
rename `Instagram` to `BentoInstagram` (#35949)
dmanek Sep 7, 2021
9e81471
BentoFitText title to 'FitText' (#35972)
caroqliu Sep 7, 2021
0f872e3
🏗 Parallelize `dist` steps (#35943)
danielrozenberg Sep 7, 2021
479a9b2
📖 BentoBaseCarousel README code fixes (#35973)
alanorozco Sep 7, 2021
71396b2
🏗 Fix `make release` bug for release tagger (#35947)
estherkim Sep 7, 2021
d068ac1
* rename InlineGallery -> BentoInlineGallery (#35876)
kvchari Sep 7, 2021
8c2e750
* rename DateCountdown -> BentoDateCountdown (#35874)
kvchari Sep 7, 2021
f1d6032
refactor(amp-stream-gallery): rename StreamGallery -> BentoStreamGall…
kvchari Sep 7, 2021
db21493
Update Storybook template to differentiate between `Foo` and `BentoFo…
caroqliu Sep 7, 2021
5a3a833
Set experiment to 1 (#35970)
mszylkowski Sep 7, 2021
9022836
Clean up some small linter issues with validator files. (#35982)
Sep 7, 2021
e9647ef
Rename `Instagram` to `BentoInstagram` (#35948)
dmanek Sep 7, 2021
9d8c7b5
Rename EmbedlyCard -> BentoEmbedlyCard (#35977)
caroqliu Sep 8, 2021
55bd45f
Make amp-form failure message developer-friendlier (#35964)
zhangsu Sep 8, 2021
12a897f
added refresh interval for amp-ad blocks in the apester-media (#35961)
golovatuy Sep 8, 2021
cd5e0a9
📖 Warn when using a consent promptUI that contains an iframe (#35986)
alanorozco Sep 8, 2021
c2d4fe6
♻️ Use Storybook `args` (second round) (#35930)
alanorozco Sep 8, 2021
c608047
📖 Add Storybook Style Recommendations (#35945)
alanorozco Sep 8, 2021
052f1d4
🖍 [Attachment Forms] Update the style of the attachment header text …
coreymasanto Sep 8, 2021
5b319f2
🏗 Update Storybook forbidden terms (#35991)
alanorozco Sep 8, 2021
3ec9cde
SwG Release 0.1.22.183 (#35997)
hartmannr76 Sep 8, 2021
acfbb19
♻️ Rename `Brightcove` to `BentoBrightcove` (#35994)
alanorozco Sep 8, 2021
0fb27fd
Pin CircleCI's Chrome version (#35916)
jridgewell Sep 8, 2021
23d195e
♻️ Provide BentoVideo (#35993)
alanorozco Sep 8, 2021
4028273
♻️ Rename `Vimeo` to `BentoVimeo` (#35995)
alanorozco Sep 8, 2021
ab254bb
♻️ Rename `Youtube` to `BentoYoutube` (#35996)
alanorozco Sep 8, 2021
80de251
🐛 [Story animations] Fix prerender resume animation (#35987)
mszylkowski Sep 8, 2021
a850e29
🏗 Enable `npm` for `amp-video` (#34819)
alanorozco Sep 8, 2021
86f7cae
📖 Add instructions to reproduce validator tests (#35980)
antiphoton Sep 8, 2021
5706482
Merge branch 'broadbandy' of github.com:BroadBandyDev/amphtml into br…
tverbert Sep 9, 2021
b050472
remove editor ignore file
tverbert Sep 14, 2021
98dc1d1
Merge branch 'main' into broadbandy
tverbert Sep 14, 2021
ea52d0b
revert register integration
tverbert Sep 14, 2021
b6e889e
remove unused import
tverbert Sep 14, 2021
6013108
change import order
tverbert Sep 16, 2021
4ffafbc
Merge branch 'main' into broadbandy
tverbert Sep 16, 2021
0dfe5a9
prettify code
tverbert Sep 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ npm-debug.log
.firebase
firebase
firebase.json

#Editor configs
.idea
BroadBandyDev marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions 3p/integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ import {bidtellect} from '#ads/vendors/bidtellect';
import {blade} from '#ads/vendors/blade';
import {brainy} from '#ads/vendors/brainy';
import {bringhub} from '#ads/vendors/bringhub';
import {broadbandy} from '#ads/vendors/broadbandy';
BroadBandyDev marked this conversation as resolved.
Show resolved Hide resolved
import {broadstreetads} from '#ads/vendors/broadstreetads';
import {byplay} from '#ads/vendors/byplay';
import {caajainfeed} from '#ads/vendors/caajainfeed';
Expand Down Expand Up @@ -374,6 +375,7 @@ register('blade', blade);
register('bodymovinanimation', bodymovinanimation);
register('brainy', brainy);
register('bringhub', bringhub);
register('broadbandy', broadbandy);
BroadBandyDev marked this conversation as resolved.
Show resolved Hide resolved
register('broadstreetads', broadstreetads);
register('byplay', byplay);
register('caajainfeed', caajainfeed);
Expand Down
11 changes: 11 additions & 0 deletions 3p/vendors/broadbandy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import '#3p/polyfills';

import {draw3p, init} from '#3p/integration-lib';
import {register} from '#3p/3p';

import {broadbandy} from '#ads/vendors/broadbandy';

init(window);
register('broadbandy', broadbandy);

window.draw3p = draw3p;
4 changes: 4 additions & 0 deletions ads/_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,10 @@ const adConfig = jsonConfiguration({
preconnect: ['https://static.bh-cdn.com', 'https://core-api.bringhub.io'],
},

'broadbandy': {
renderStartImplemented: true,
},

'broadstreetads': {
prefetch: 'https://cdn.broadstreetads.com/init-2.min.js',
renderStartImplemented: true,
Expand Down
25 changes: 25 additions & 0 deletions ads/vendors/broadbandy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import {loadScript, validateData} from '#3p/3p';

/**
* @param {!Window} global
* @param {!Object} data
*/
export function broadbandy(global, data) {
validateData(data, ['template', 'domain']);
data.url = 'https://bb1.broadbandy.net/amp/app.js';
data.id = '6d3674c49af4071e414d4adbab038085';
createIns(global, data);
loadScript(global, data.url);
}

/**
* @param {!Window} global
* @param {!Object} data
*/
function createIns(global, data) {
const ins = global.document.createElement('ins');
ins.setAttribute('data-id', data.id);
ins.setAttribute('data-template', data['template']);
ins.setAttribute('data-domain', data['domain']);
global.document.getElementById('c').appendChild(ins);
}
15 changes: 15 additions & 0 deletions ads/vendors/broadbandy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# DigitalExchange

## Example

```html
<amp-ad
type="broadbandy"
data-template="inarticle_ima"
data-domain="test.dev">
</amp-ad>
```

### Required parameters

- `data-template`
5 changes: 5 additions & 0 deletions examples/amp-ad/ads.amp.html
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
<option>blade</option>
<option>brainy</option>
<option>bringhub</option>
<option>broadbandy</option>
<option>byplay</option>
<option>caajainfeed</option>
<option>capirs</option>
Expand Down Expand Up @@ -965,6 +966,10 @@ <h2>Broadstreet Ads</h2>
<div fallback></div>
</amp-ad>

<h2>broadbandy</h2>
<amp-ad width="300" height="250" type="broadbandy" data-template="inarticle_ima" data-domain="techwave.io">
</amp-ad>

<h2>Bringhub Mini-Storefront</h2>
<amp-embed width="600" height="320" type="bringhub" layout="responsive"
heights="(max-width: 270px) 1280px, (max-width:553px) 640px, 338px">
Expand Down
1 change: 1 addition & 0 deletions extensions/amp-ad/amp-ad.md
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ See [amp-ad rules](validator-amp-ad.protoascii) in the AMP validator specificati
- [Blade](../../ads/vendors/blade.md)
- [brainy](../../ads/vendors/brainy.md)
- [Broadstreet Ads](../../ads/vendors/broadstreetads.md)
- [Broadbandy](../../ads/vendors/broadbandy.md)
- [ByPlay](../../ads/vendors/byplay.md)
- [CA A.J.A. Infeed](../../ads/vendors/caajainfeed.md)
- [CA-ProFit-X](../../ads/vendors/caprofitx.md)
Expand Down