Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] allow user to override amp-img placeholder and hook into active and hidden class #363

Closed
wants to merge 1 commit into from

Conversation

erwinmombay
Copy link
Member

No description provided.

@cramforce
Copy link
Member

Why don't we allow overriding the default image placeholder classes?

@erwinmombay
Copy link
Member Author

@cramforce i think that was just because we wanted to start inclusively with the placeholder and start opening up the hooks. after playing around with it some more, i don't think theres going to be much harm with making -amp-autoplaceholder (private) into amp-autoplaceholder (public) as the developer can shoot themselves in the foot anyways if they add their own placeholder so might as well make the default classes public.

@erwinmombay erwinmombay changed the title allow user to override amp-img placeholder and hook into active and hidden class [WIP] allow user to override amp-img placeholder and hook into active and hidden class Sep 30, 2015
@erwinmombay
Copy link
Member Author

/cc @dvoytenko if you have any concerns on making the default auto-placeholder classes user stylable.

@erwinmombay
Copy link
Member Author

for reference => #339

@dvoytenko
Copy link
Contributor

I could see making them immediately public if we didn't have special HTML in there to make it work, e.g. loader dots. I'm not sure we are quite ready. We have to make it customizable, but I'd prefer to do it post preview.

@cramforce
Copy link
Member

Fine with me!

@erwinmombay erwinmombay self-assigned this Oct 9, 2015
@dvoytenko
Copy link
Contributor

Looks like we can close it? I'm closing. Please reopen if disagree.

@dvoytenko dvoytenko closed this Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants