Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Story loading] Send storyContentLoaded during prerendering #36307

Merged
merged 17 commits into from
Oct 14, 2021
Merged

🐛 [Story loading] Send storyContentLoaded during prerendering #36307

merged 17 commits into from
Oct 14, 2021

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Oct 8, 2021 •
edited
Loading

Closes #36288
Closes #36571

Should call markStoryAsLoaded on prerender when the first page contains an image or a video with cached source.

@mszylkowski mszylkowski self-assigned this Oct 8, 2021
@mszylkowski mszylkowski added this to In progress in wg-stories Sprint via automation Oct 8, 2021
@mszylkowski mszylkowski marked this pull request as ready for review October 11, 2021 18:10
@amp-owners-bot
Copy link

amp-owners-bot bot commented Oct 11, 2021 •
edited
Loading

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story.js

gmajoulet
gmajoulet approved these changes Oct 11, 2021
View reviewed changes
extensions/amp-story/1.0/amp-story-page.js Outdated Show resolved Hide resolved
@mszylkowski mszylkowski enabled auto-merge (squash) October 11, 2021 20:19
@mszylkowski mszylkowski merged commit 73201d9 into ampproject:main Oct 14, 2021
wg-stories Sprint automation moved this from In progress to Done Oct 14, 2021
@mszylkowski mszylkowski deleted the initializepages_loadevent branch October 14, 2021 20:10
@processprocess processprocess mentioned this pull request Oct 25, 2021
Open
@mszylkowski mszylkowski mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

@mszylkowski mszylkowski

Labels
PR use: In LTS PR use: In Stable
Projects
wg-stories Sprint
  
Done
Milestone
No milestone
3 participants
@mszylkowski @gmajoulet @ampprojectbot