use the version flag if provided #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cramforce PTAL |
|
LGTM |
erwinmombay
force-pushed
the
version-repro
branch
from
9530c03
to
0266e70
Compare
mdmower
added a commit
to mdmower/amphtml
that referenced
this pull request
Mar 14, 2020
Revise several changes made in PR ampproject#27196: - 'number' was misspelled several times in TESTING.md and is not a necessary word anyways. Remove 'number' from descriptions of flag. - Flag --version has been supported since 2016 (ampproject#3702). It was inappropriate to simply remove support for the flag, when it can be left in-place without any harm to the build system. - `rtv_version` is not a good choice of name, it reads like "runtime version version" and runtime versions differ from release versions (runtime version includes config number and release version number). Opt for `release_version` which lines up with the version listed on the release page https://github.com/ampproject/amphtml/releases.
mdmower
added a commit
that referenced
this pull request
Mar 20, 2020
* build: Restore --version flag support, update new flag name Revise several changes made in PR #27196: - 'number' was misspelled several times in TESTING.md and is not a necessary word anyways. Remove 'number' from descriptions of flag. - Flag --version has been supported since 2016 (#3702). It was inappropriate to simply remove support for the flag, when it can be left in-place without any harm to the build system. - `rtv_version` is not a good choice of name, it reads like "runtime version version" and runtime versions differ from release versions (runtime version includes config number and release version number). Opt for `release_version` which lines up with the version listed on the release page https://github.com/ampproject/amphtml/releases. * Revisions based on review - `--version` flag is not allowed to be reintroduced - `release_version` not accepted, using `version_override` instead - Document `--custom_version_mark` flag
twintwox
pushed a commit
to twintwox/amphtml
that referenced
this pull request
Mar 24, 2020
* build: Restore --version flag support, update new flag name Revise several changes made in PR ampproject#27196: - 'number' was misspelled several times in TESTING.md and is not a necessary word anyways. Remove 'number' from descriptions of flag. - Flag --version has been supported since 2016 (ampproject#3702). It was inappropriate to simply remove support for the flag, when it can be left in-place without any harm to the build system. - `rtv_version` is not a good choice of name, it reads like "runtime version version" and runtime versions differ from release versions (runtime version includes config number and release version number). Opt for `release_version` which lines up with the version listed on the release page https://github.com/ampproject/amphtml/releases. * Revisions based on review - `--version` flag is not allowed to be reintroduced - `release_version` not accepted, using `version_override` instead - Document `--custom_version_mark` flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.