Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CloseWatcher API in amp-lightbox 0.1 #37099

Merged
merged 5 commits into from
Dec 31, 2021
Merged

Use CloseWatcher API in amp-lightbox 0.1 #37099

merged 5 commits into from
Dec 31, 2021

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Dec 2, 2021 •
edited
Loading

Use CloseWatcher API for amp-lightbox 0.1. It's supposed to be launched in Chrome 98. Some key benefits of this new API:

  1. Reduces reliance on a global window.history.
  2. Provides cleaner per-platform behavior. For instance, if platform has its own "close" gesture, then it's channeled via this API.

TODO:

  • Tests

@dvoytenko dvoytenko changed the title User CloseWatcher API in amp-lightbox 0.1 Use CloseWatcher API in amp-lightbox 0.1 Dec 2, 2021
@dvoytenko dvoytenko marked this pull request as ready for review December 31, 2021 00:11
@dvoytenko dvoytenko merged commit 17a40da into ampproject:main Dec 31, 2021
@dvoytenko dvoytenko deleted the closewatcher/start branch December 31, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvoytenko @jridgewell @ampprojectbot