Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [Story performance] Remove unused strings from localization bundles #37229

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Dec 15, 2021

We can remove 5 strings from all localization bundles and deprecate 11 strings from the strings.js map.

Closes #37197

dist/v0/amp-story-0.1.mjs: Δ -1.20KB
dist/v0/amp-story-1.0.mjs: Δ -1.20KB
dist/v0/amp-story-0.1.js: Δ -1.37KB
dist/v0/amp-story-1.0.js: Δ -1.37KB

Also will remove strings from system layer redesign on: #37218

@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/_locales/af.json
extensions/amp-story/1.0/_locales/am.json
extensions/amp-story/1.0/_locales/ar.json
extensions/amp-story/1.0/_locales/bg.json
extensions/amp-story/1.0/_locales/bn.json
extensions/amp-story/1.0/_locales/bs.json
extensions/amp-story/1.0/_locales/ca.json
extensions/amp-story/1.0/_locales/cs.json
extensions/amp-story/1.0/_locales/da.json
extensions/amp-story/1.0/_locales/de.json
extensions/amp-story/1.0/_locales/el.json
extensions/amp-story/1.0/_locales/en-GB.json
+60 more

@mszylkowski mszylkowski self-assigned this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story performance] Remove system sharing localization strings as it shouldn't be used
3 participants