Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 amp-story-shopping Added correct margins for RTL mode #37568

Merged
merged 8 commits into from
Feb 10, 2022

Conversation

jshamble
Copy link
Contributor

@jshamble jshamble commented Feb 3, 2022

Added correct margins for RTL mode. An accompaniment PR to #37195

@jshamble jshamble self-assigned this Feb 3, 2022
@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 3, 2022

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-tag.css
extensions/amp-story-shopping/0.1/amp-story-shopping-tag.js

@jshamble jshamble added this to In progress in wg-stories Shopping Feb 3, 2022
@coreymasanto
Copy link
Contributor

I'll defer to @processprocess for approving these CSS changes

@coreymasanto coreymasanto removed their request for review February 10, 2022 01:05
@jshamble jshamble requested review from processprocess and coreymasanto and removed request for coreymasanto February 10, 2022 03:46
@processprocess processprocess added this to In progress in wg-stories Sprint via automation Feb 10, 2022
@jshamble jshamble merged commit 37b830a into ampproject:main Feb 10, 2022
wg-stories Sprint automation moved this from In progress to Done Feb 10, 2022
wg-stories Shopping automation moved this from In progress to Done Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants