Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement function that allocate variant based on an experiment config. #3762

Merged
merged 9 commits into from Jun 28, 2016
Merged

Implement function that allocate variant based on an experiment config. #3762

merged 9 commits into from Jun 28, 2016

Commits on Jun 23, 2016

  1. Implement function that allocate variant based on an experiment config.

    @lannka
    lannka committed Jun 23, 2016
    Copy the full SHA
    daec8ef View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2016

  1. Fix lint errors.

    @lannka
    lannka committed Jun 24, 2016
    Copy the full SHA
    8d26045 View commit details
    Browse the repository at this point in the history

  2. Loop through object property in fixed order as the iteration order of… 

    … for..in loop is browser dependent.
    @lannka
    lannka committed Jun 24, 2016
    Copy the full SHA
    ef6c310 View commit details
    Browse the repository at this point in the history

  3. Address review comments.

    @lannka
    lannka committed Jun 24, 2016
    Copy the full SHA
    078bad8 View commit details
    Browse the repository at this point in the history

  4. Address comments.

    @lannka
    lannka committed Jun 24, 2016
    Copy the full SHA
    ed7e91f View commit details
    Browse the repository at this point in the history

  5. Fix the potential problem from the float precision error.

    @lannka
    lannka committed Jun 24, 2016
    Copy the full SHA
    4bfbc9f View commit details
    Browse the repository at this point in the history

  6. not.to.throw -> to.not.throw

    @lannka
    lannka committed Jun 24, 2016
    Copy the full SHA
    cff4665 View commit details
    Browse the repository at this point in the history

  7. Repositioning the comment.

    @lannka
    lannka committed Jun 24, 2016
    Copy the full SHA
    fbc8b65 View commit details
    Browse the repository at this point in the history

  8. Address comment

    @lannka
    lannka committed Jun 24, 2016
    Copy the full SHA
    e85533d View commit details
    Browse the repository at this point in the history