Implement function that allocate variant based on an experiment config. #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for..in loop is browser dependent.
| * experiment config. | ||
| * @param {!Window} win | ||
| * @param {!Object} config | ||
| * @return {Promise<?string>} |
There was a problem hiding this comment.
Please add either ? or ! - we require it for all types except for primitives.
There was a problem hiding this comment.
meaning to Promise, e.g. !Promise
|
@lannka Is there spec you are working off that I can now see? |
| */ | ||
| function getBucketTicket(win, opt_cidScope) { | ||
| if (opt_cidScope) { | ||
| // TODO(lannka): implement CID |
There was a problem hiding this comment.
For implementation TODO's (especially major ones) we require this format:
TODO(@name, #bug): description
This way we can create/close github issues for better tracking and visibility.
|
The spec: https://docs.google.com/document/d/1YjT3WxB_ck43d16ONE-AwsKVx1eqikCFdq4lArtbHSA/edit# All comments addressed. PTAL. |
|
@jridgewell @dvoytenko PTAL |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only handles non-sticky case (CID not used).
This is the 2nd PR for #1411