♻️ Migrate gallery 35..39 to controls #37727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvchari
force-pushed
the
migrate-gallery-to-controls
branch
3 times, most recently
from
db2e43b
to
2728b9c
Compare
kvchari
changed the title
kvchari
force-pushed
the
migrate-gallery-to-controls
branch
from
2728b9c
to
8b7763b
Compare
13 tasks
kvchari
changed the title
13 tasks
alanorozco
reviewed
Feb 22, 2022
| 'extensions/amp-selector/1.0/storybook/Basic.amp.js', | ||
| 'extensions/amp-selector/1.0/storybook/Basic.js', | ||
| 'extensions/amp-sidebar/0.1/storybook/Basic.amp.js', | ||
| 'extensions/amp-sidebar/1.0/storybook/Basic.amp.js', | ||
| 'extensions/amp-sidebar/1.0/storybook/Basic.js', | ||
| 'extensions/amp-soundcloud/1.0/storybook/Basic.amp.js', | ||
| 'extensions/amp-soundcloud/1.0/storybook/Basic.js', | ||
| 'extensions/amp-stream-gallery/1.0/storybook/Basic.amp.js', | ||
| 'extensions/amp-stream-gallery/1.0/storybook/Basic.js', |
There was a problem hiding this comment.
We should be able to approve this file but I messed up the ownership. Please pull after merging #37751, and we should be able to merge this PR.
There was a problem hiding this comment.
I rebased and force pushed, but I'm still seeing a "missing owners approval" red flag
kvchari
force-pushed
the
migrate-gallery-to-controls
branch
from
8b7763b
to
3470fa2
Compare
rsimha
approved these changes
Feb 22, 2022
kvchari
force-pushed
the
migrate-gallery-to-controls
branch
from
3470fa2
to
53dfb89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial: #35923