♻️Migrate Stories 62..65 to args
#37730
Conversation
Remove disabled stories, and all its uses and remove storybook allowlist.
|
Hey @alanorozco! These files were changed: |
rbeckthomas
changed the title
args:wargs
|
@rebeccanthomas: is this ready for review? |
rbeckthomas
requested review from
alanorozco
and removed request for
alanorozco and
samouri
|
Ah, Not yet. This is blocked pending the merges of the other story migration. Sorry about that! |
src/preact/storybook/Wrappers.js
Outdated
| aria-label={ariaLabel} | ||
| {...args} |
There was a problem hiding this comment.
args contains some of the same properties that are passed in. Perhaps you want to do:
<ContainWrapper {...args} as={asProp} class={className} ...
may be a part of the args.
| defaultValue: {border: '1px solid', width: 200, height: 50}, | ||
| control: {type: 'object'}, | ||
| }, | ||
| wrapperStyle: { |
There was a problem hiding this comment.
does this need the default value of {padding: 4}?
There was a problem hiding this comment.
ah yes! thank you :)
| }; | ||
|
|
||
| const IMG_SRC = | ||
| "data:image/svg+xml;charset=utf-8,%3Csvg xmlns='http://www.w3.org/2000/svg' width='24px' height='24px' viewBox='0 0 24 24' fill='%23000000'%3E%3Cpath d='M0 0h24v24H0z' fill='none'/%3E%3Cpath d='M9 16.17L4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z'/%3E%3C/svg%3E"; | ||
|
|
||
| const LOADING_OPTIONS = ['auto', 'lazy', 'eager', 'unload']; | ||
|
|
||
| export const _default = () => { |
There was a problem hiding this comment.
FMI: why is this named _default? Does that do something?
There was a problem hiding this comment.
As a convention we name the first story _default to make it clear its one that gets default selected when you navigate to the story. It doesnt do anything special in the storybook its more just for us
the default on line 9/6 That one does some storybook internal magic and is important to be named that way
Partial for #35923.
This PR also removes the allowlist for the usage of
@storybook/addon-knobsand references to it.