Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Migrate Stories 45..49 to args #37850

Merged
merged 15 commits into from
Mar 15, 2022
Merged

♻️ Migrate Stories 45..49 to args #37850

merged 15 commits into from
Mar 15, 2022

Commits on Feb 17, 2022

  1. Remove knobs from selector and sidebar storybooks.

    @rbeckthomas
    rbeckthomas committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d16ecdb View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Remove knobs from amp sidebar storybook.

    @rbeckthomas
    rbeckthomas committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    5c889d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Knobs Migration: Respond to reviewer comments.

    @rbeckthomas
    rbeckthomas committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    8fb3eb8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:ampproject/amphtml into remove-knobs

    @rbeckthomas
    rbeckthomas committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    c690339 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Add comment to add clarity to the options in bento-sidebar's storyb… 

    …ook.
    @rbeckthomas
    rbeckthomas committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    eda2312 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:ampproject/amphtml into remove-knobs

    @rbeckthomas
    rbeckthomas committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    aa930a9 View commit details
    Browse the repository at this point in the history

  3. Add comments for clarity in usage of undefined.

    @rbeckthomas
    rbeckthomas committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    b425dcb View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Merge branch 'main' of github.com:ampproject/amphtml into remove-knobs

    @rbeckthomas
    rbeckthomas committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    a3bbd6f View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Merge branch 'main' of github.com:ampproject/amphtml into remove-knobs

    @rbeckthomas
    rbeckthomas committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    2af18ce View commit details
    Browse the repository at this point in the history

  2. Convert knobs to controls in stories for lightbox, soundcloud, and 

    timeago.
    @rbeckthomas
    rbeckthomas committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    1760d9f View commit details
    Browse the repository at this point in the history

  3. Reorder variable declarations to be before their first use.

    @rbeckthomas
    rbeckthomas committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    7423e24 View commit details
    Browse the repository at this point in the history

  4. Fix capitalization error and missing return statement.

    @rbeckthomas
    rbeckthomas committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    84c2e8c View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Move controls with type boolean, string, or number from argTypes to 

    args.
    @rbeckthomas
    rbeckthomas committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    a6c023f View commit details
    Browse the repository at this point in the history

  2. Move inferrable controls from argtypes to args

    @rbeckthomas
    rbeckthomas committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    a5b1694 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:ampproject/amphtml into remove-knobs

    @rbeckthomas
    rbeckthomas committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    43625cb View commit details
    Browse the repository at this point in the history