-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Migrate Stories 45..49 to args
#37850
Conversation
This pull request introduces 1 alert when merging 1760d9f into b70a0f3 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: argTypes
where the key matches the name
property in the value can just be in args
(except types that don't get automatically inferred correctly by their defaultValue like type: 'color'
).
also args should have names that match the name of the component's property/attribute binding, so we don't have to extract and rename the variable (e.g should use data-trackid
instead of trackId
).
Partial for #35923.