Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Story bodymoving] Support amp-bodymovin-animation on amp-story-grid-layer #38239

Merged
merged 31 commits into from
May 26, 2022

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented May 26, 2022

Fixes #38165

We want to support amp-bodymovin-animation elements in amp-story.

The BodyMovin animations are connected to the same play/pause cycle as amp-story-animation so that they play/pause with the page (when transitioningbetween pages, when long-pressing, etc). Also follows the prefers-reduced-motion user preference. This is implemented with a new BodymovinAnimationRunner with the same API as the AnimationRunner that runs web animations, so that the AnimationManager can apply all the operations to all the runners (both implementations) in the same way.

dist/v0/amp-story-0.1.mjs: Δ +0.11KB
dist/v0/amp-story-1.0.mjs: Δ +0.11KB
dist/v0/amp-story-0.1.js: Δ +0.13KB
dist/v0/amp-story-1.0.js: Δ +0.13KB

@mszylkowski mszylkowski self-assigned this May 26, 2022
@mszylkowski mszylkowski marked this pull request as ready for review May 26, 2022 16:54
@amp-owners-bot
Copy link

amp-owners-bot bot commented May 26, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.css
extensions/amp-story/1.0/animation.js
extensions/amp-story/validator-amp-story.protoascii

Hey @ampproject/wg-caching! These files were changed:

extensions/amp-story/validator-amp-story.protoascii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AMP Story] Update amp validator to accept amp-bodymovin-animation
4 participants