✨ [Story bodymoving] Support amp-bodymovin-animation on amp-story-grid-layer #38239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of github.com:ampproject/amphtml
|
Hey @gmajoulet, @newmuis! These files were changed: Hey @ampproject/wg-caching! These files were changed: |
gmajoulet
approved these changes
May 26, 2022
honeybadgerdontcare
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38165
We want to support
amp-bodymovin-animationelements in amp-story.The BodyMovin animations are connected to the same play/pause cycle as
amp-story-animationso that they play/pause with the page (when transitioningbetween pages, when long-pressing, etc). Also follows theprefers-reduced-motionuser preference. This is implemented with a newBodymovinAnimationRunnerwith the same API as theAnimationRunnerthat runs web animations, so that theAnimationManagercan apply all the operations to all the runners (both implementations) in the same way.