[amp-experiment] Allocate experiment variant based on CID. #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, deferring final LGTM to @jridgewell |
| return hasConsentPromise | ||
| .then(hasConsent => { | ||
| if (!hasConsent) { | ||
| return null; |
There was a problem hiding this comment.
I'm not sure we want to return null here. Imagine the user hasn't dismissed the consent notification yet, but will eventually. We're specifically not allocating this user into a variant since we can't get consent (we can't render block forever). But this is distinct from allocating the user into the null variant below (because the publisher didn't provide a full 100% distribution of variants).
There was a problem hiding this comment.
Good point. This has been discussed during the design, and we decided to skip such an experiment on users first several visits until user has given the consent.
|
One comment, code LGTM. |
|
Thanks folks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1411