Allow variant to be overridden from URL fragment #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +36,12 @@ export function allocateVariant(win, experimentName, config) { | |||
| assertName(experimentName); | |||
| validateConfig(config); | |||
|
|
|||
| // Variant can be overridden from URL fragment. | |||
| const override = viewerFor(win).getParam(ATTR_PREFIX + experimentName); | |||
| if (override && config.variants.hasOwnProperty(override)) { | |||
There was a problem hiding this comment.
For stronger safety, I suggest doing this in getVariantOverride_() so invalid values never make it to the overrides map to start with.
There was a problem hiding this comment.
Sorry, I don't quite understand. Are you suggesting to extract a method named getVariantOverride_()? Why would that be safer?
There was a problem hiding this comment.
sorry this comment was based on the code in #4079. I see that PR is closed. This is fine, ignore my previous comment.
|
|
|
Comment addressed. PTAL |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1411
A re-try to address comments in #4079