Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example of usage of carousel arrows #5397

Merged
merged 2 commits into from Oct 7, 2016
Merged

Added example of usage of carousel arrows #5397

merged 2 commits into from Oct 7, 2016

Conversation

alex-moreno
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@alex-moreno
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jridgewell jridgewell assigned ghost Oct 4, 2016
@jridgewell
Copy link
Contributor

/to @bpaduch

ghost
ghost suggested changes Oct 5, 2016
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please specify "html" as the code language. For example:

<amp....

@ghost
Copy link

ghost commented Oct 5, 2016

What I mean is in the markdown, like so:

```html
<amp-carousel ...

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@alex-moreno
Copy link
Contributor Author

sure thing @bpaduch , done. Thanks for the review

@jridgewell jridgewell added the LGTM label Oct 6, 2016
@jridgewell
Copy link
Contributor

@erwinmombay: Can you force merge?

@erwinmombay erwinmombay merged commit f505854 into ampproject:master Oct 7, 2016
samiamorwas pushed a commit to samiamorwas/amphtml that referenced this pull request Oct 10, 2016
Merge branch 'master' of https://github.com/ampproject/amphtml into a…
d6126b1 
…mp_reddit_extension

* 'master' of https://github.com/ampproject/amphtml: (65 commits)
  Send vars from carousel to amp-analytics (ampproject#5388)
  Rolling back pan-x on scrollable carousel. (ampproject#5490)
  Add context.library.name to Segment (ampproject#5467)
  Rollback pan-x on carousel as it does not work on android. (ampproject#5473)
  cron job from @erwinmombay to update size.txt (ampproject#5468)
  Added example of usage of carousel arrows (ampproject#5397)
  ALP for A4A (ampproject#5430)
  Add Affiliate-B support for amp-ad (ampproject#5223)
  First cut of changes for New Type Inference (ampproject#5438)
  Lightbox 2.0: Use object-fit:cover for thumbnails
  Upgrade Closure Compiler to v20160911 (Sep 11, 2016) (ampproject#5457)
  Fake and real window fixtures for tests (ampproject#5425)
  Backgrounded Variable added to Timer Trigger (ampproject#5240)
  make `touch-action: pan-x` on `amp-carousel` (ampproject#5391)
  Fix PR check on new branches (ampproject#5455)
  Do not rely on ampExtendedElements being created (ampproject#5454)
  Turn type checking for 3p code back on. (ampproject#5452)
  Update ads/README.md with gulp lint tip (ampproject#5444)
  Migrate document-submit to doc scope (ampproject#5437)
  Link to Building an AMP Extension document. (ampproject#5451)
  ...
dreamofabear pushed a commit to dreamofabear/amphtml that referenced this pull request Oct 12, 2016
@alex-moreno
Added example of usage of carousel arrows (ampproject#5397)
072f1f8 
* Added example of usage of carousel arrows

* Added type of markdown (html)
mkhatib pushed a commit to mkhatib/amphtml that referenced this pull request Oct 14, 2016
@alex-moreno @mkhatib
Added example of usage of carousel arrows (ampproject#5397)
38d9b9c 
* Added example of usage of carousel arrows

* Added type of markdown (html)
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
@alex-moreno
Added example of usage of carousel arrows (ampproject#5397)
617546d 
* Added example of usage of carousel arrows

* Added type of markdown (html)
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
@alex-moreno
Added example of usage of carousel arrows (ampproject#5397)
0fbb543 
* Added example of usage of carousel arrows

* Added type of markdown (html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
Related to: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex-moreno @googlebot @jridgewell @erwinmombay