ALP for A4A #5430
Merged
ALP for A4A #5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
cramforce
approved these changes
Oct 7, 2016
| if (!isExperimentOn(this.win, 'alp-for-a4a')) { | ||
| return; | ||
| } | ||
| iframeWin.addEventListener('click', event => { |
There was a problem hiding this comment.
Does this work? I think iframeWin.document.documentElement would be more idiomatic.
There was a problem hiding this comment.
Ha! changed to register listener on element.
samiamorwas
pushed a commit
to samiamorwas/amphtml
that referenced
this pull request
Oct 10, 2016
…mp_reddit_extension * 'master' of https://github.com/ampproject/amphtml: (65 commits) Send vars from carousel to amp-analytics (ampproject#5388) Rolling back pan-x on scrollable carousel. (ampproject#5490) Add context.library.name to Segment (ampproject#5467) Rollback pan-x on carousel as it does not work on android. (ampproject#5473) cron job from @erwinmombay to update size.txt (ampproject#5468) Added example of usage of carousel arrows (ampproject#5397) ALP for A4A (ampproject#5430) Add Affiliate-B support for amp-ad (ampproject#5223) First cut of changes for New Type Inference (ampproject#5438) Lightbox 2.0: Use object-fit:cover for thumbnails Upgrade Closure Compiler to v20160911 (Sep 11, 2016) (ampproject#5457) Fake and real window fixtures for tests (ampproject#5425) Backgrounded Variable added to Timer Trigger (ampproject#5240) make `touch-action: pan-x` on `amp-carousel` (ampproject#5391) Fix PR check on new branches (ampproject#5455) Do not rely on ampExtendedElements being created (ampproject#5454) Turn type checking for 3p code back on. (ampproject#5452) Update ads/README.md with gulp lint tip (ampproject#5444) Migrate document-submit to doc scope (ampproject#5437) Link to Building an AMP Extension document. (ampproject#5451) ...
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Oct 12, 2016
mkhatib
pushed a commit
to mkhatib/amphtml
that referenced
this pull request
Oct 14, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #5212
target = _blankin the case of A2A redirect. This is a preference thing, I would vote for open in new window since user specifically ask fortarget=_blank.cc @jasti