Add a newInstance method for creating a validator instance, #5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is synchronous and much simpler than the existing getInstance method (it's just a constructor call thus far).
|
The point of this is that with this change, I should then be able to replace most of this file https://github.com/ampproject/ampbench/blob/master/ampbench_validator.js with a call to newInstance. Alternative would be to expose the constructor of the Validator class, but I think the creation method is useful as a little hedge that allows future changes. |
honeybadgerdontcare
approved these changes
Oct 12, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
…ct#5534) * Add a newInstance method for creating a validator instance, which is synchronous and much simpler than the existing getInstance method (it's just a constructor call thus far). * fix typo
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
…ct#5534) * Add a newInstance method for creating a validator instance, which is synchronous and much simpler than the existing getInstance method (it's just a constructor call thus far). * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is synchronous and much simpler than the existing getInstance method
(it's just a constructor call thus far).