Allow dot character in CID fallback cookie #5757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdufour
force-pushed
the
feature/allow-dot-character
branch
from
a9d9b15
to
35a0c25
Compare
pdufour
force-pushed
the
feature/allow-dot-character
branch
from
35a0c25
to
c863981
Compare
|
/to @cramforce |
|
Change looks good. Please ping this on Monday as it appears that our bots are currently down due to the DYN dns outage. |
|
Pinging @cramforce |
|
Restarted build. |
cramforce
approved these changes
Oct 24, 2016
|
Thanks @cramforce, any chance this made it into the latest release? |
|
It did not make this week's (last week's really, but the DNS outage) canary cut. It'll go into canary on Thursday after this week's (real) cut. |
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #5729. This allows the extra
.character to be used for the cid name. Useful for instance if you are migrating from an existing system that used.characters in their cookies.