Separate out implementaton of document-info and remove dependency of … #5864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Oct 27, 2016
| */ | ||
| export function documentInfoForDoc(nodeOrDoc) { | ||
| return /** @type {!DocumentInfoDef} */ (getServiceForDoc(nodeOrDoc, |
There was a problem hiding this comment.
Where's this code gone?
jridgewell
reviewed
Oct 27, 2016
| : sourceUrl; | ||
| } | ||
| const pageViewId = getPageViewId(this.ampdoc_.win); | ||
| return this.info_ = {url, sourceUrl, canonicalUrl, pageViewId}; |
There was a problem hiding this comment.
Per #5606 (comment), how about not caching the url and sourceUrl attributes? This is wayy better than having a getter property.
There was a problem hiding this comment.
Yeah, but this is a refactoring. Don't want to make any changes not related to that.
|
Friendly ping. |
|
@erwinmombay or me? |
jridgewell
approved these changes
Oct 28, 2016
|
💃 |
|
Either or :) |
erwinmombay
reviewed
Oct 28, 2016
| function getPageViewId(win) { | ||
| return String(Math.floor(win.Math.random() * 10000)); | ||
| return /** @type {!./service/document-info-impl.DocInfo} */ ( | ||
| getExistingServiceForDoc(nodeOrDoc, 'documentInfo')).get(); |
There was a problem hiding this comment.
is this .get() new? don't think ive seen this before
There was a problem hiding this comment.
nvm looks like its newly added for the cached value
erwinmombay
approved these changes
Oct 28, 2016
…3p-frame on services. Together this improves code size for `3p-frame` based and some other extensions. Part of ampproject#5792
cramforce
force-pushed
the
3p-frame-service-use
branch
from
c749b60
to
b7f7f2c
Compare
samiamorwas
pushed a commit
to samiamorwas/amphtml
that referenced
this pull request
Oct 31, 2016
…mp_reddit_extension * 'master' of https://github.com/ampproject/amphtml: (121 commits) `#setOwner` should rewrite `resource.owner_` value if it exist (ampproject#5898) Defer full upgrade until the element is connected (ampproject#5908) Skeleton for an amp-animation component (ampproject#5891) Use upgrade callback to pick the correct carousel class. (ampproject#5899) Add alert role to user-notification by default (ampproject#5896) Fix test-iframe-createIframeWithMessageStub failures on older browsers (ampproject#5895) Make screen readers announce changes in the slides carousel. (ampproject#5892) Separate out implementaton of document-info and remove dependency of … (ampproject#5864) Fixed assertion in key fetch function. (ampproject#5854) Track impression on amp landing page (ampproject#5606) Backward compatible way of stringifying Uint8Array (ampproject#5881) Ensure that a friendly-iframe embed cancels any boilerplate when ready (ampproject#5863) Fix amp-forms broken and flakey tests. (ampproject#5835) Make SW test properly skip when Request == undefined (ampproject#5876) Add Preamble section to AMP Cache Guidelines (ampproject#5873) Adding Adverline to amp-ad (ampproject#5829) Clarify cache guidelines (ampproject#5874) Consider it as non-viewer mode if there is no "origin" in hash param. (ampproject#5867) [amp-youtube] autoplay and test suite to run across all video players that implement the video API (ampproject#5765) Update Forms Docs to reflect availability. (ampproject#5815) ...
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
ampproject#5864) Together this improves code size for `3p-frame` based and some other extensions. Part of ampproject#5792
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
ampproject#5864) Together this improves code size for `3p-frame` based and some other extensions. Part of ampproject#5792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…3p-frame on services.
Together this improves code size for
3p-framebased and some other extensions.Part of #5792