#setOwner should rewrite resource.owner_ value if it exist
#5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Oct 28, 2016
| @@ -99,6 +99,9 @@ export class Resource { | |||
| */ | |||
| static setOwner(element, owner) { | |||
| dev().assert(owner.contains(element), 'Owner must contain the element'); | |||
| if (Resource.forElementOptional(element)) { | |||
| Resource.forElementOptional(element).owner_ = owner; | |||
There was a problem hiding this comment.
I'm not sure how I feel about touching someone else's private property. If we keep the #setOwner instance method, we could just call that.
There was a problem hiding this comment.
we can have another non static setOwner method in resource class which we use to set this.owner_?
|
To solve the nested element owner change, I can't use |
|
I don't think we can make |
|
Looks fine to me, deferring to @dvoytenko. |
dvoytenko
approved these changes
Oct 29, 2016
samiamorwas
pushed a commit
to samiamorwas/amphtml
that referenced
this pull request
Oct 31, 2016
…mp_reddit_extension * 'master' of https://github.com/ampproject/amphtml: (121 commits) `#setOwner` should rewrite `resource.owner_` value if it exist (ampproject#5898) Defer full upgrade until the element is connected (ampproject#5908) Skeleton for an amp-animation component (ampproject#5891) Use upgrade callback to pick the correct carousel class. (ampproject#5899) Add alert role to user-notification by default (ampproject#5896) Fix test-iframe-createIframeWithMessageStub failures on older browsers (ampproject#5895) Make screen readers announce changes in the slides carousel. (ampproject#5892) Separate out implementaton of document-info and remove dependency of … (ampproject#5864) Fixed assertion in key fetch function. (ampproject#5854) Track impression on amp landing page (ampproject#5606) Backward compatible way of stringifying Uint8Array (ampproject#5881) Ensure that a friendly-iframe embed cancels any boilerplate when ready (ampproject#5863) Fix amp-forms broken and flakey tests. (ampproject#5835) Make SW test properly skip when Request == undefined (ampproject#5876) Add Preamble section to AMP Cache Guidelines (ampproject#5873) Adding Adverline to amp-ad (ampproject#5829) Clarify cache guidelines (ampproject#5874) Consider it as non-viewer mode if there is no "origin" in hash param. (ampproject#5867) [amp-youtube] autoplay and test suite to run across all video players that implement the video API (ampproject#5765) Update Forms Docs to reflect availability. (ampproject#5815) ...
lannka
pushed a commit
that referenced
this pull request
Oct 31, 2016
* fix * add test * add instance method to update owner value
1 task
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
…oject#5898) * fix * add test * add instance method to update owner value
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
…oject#5898) * fix * add test * add instance method to update owner value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend #3595
fix #5862
I didn't fix nested element owner update in this PR.