adds support for Gemius analytics #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @lannka |
|
Sorry, meant @avimehta |
avimehta
reviewed
Dec 9, 2016
|
|
||
| Type attribute value: `gemius` | ||
|
|
||
| Adds support for Gemius Audience/Prism analytics. Additionally, the gemius-provided `prefix` and `identifier` variables must be specified. It's also possible to specify the optional variable `extraparams` (key1=value1|key2=value2). |
There was a problem hiding this comment.
are | and = supposed to encoded in extraUrlParams? If they are supposed to be encoded, please use extraUrlParams feature. if not, then this is fine.
There was a problem hiding this comment.
We accept (in GET request) a single additional parameter named extra. A value of that parameter should be a uri encoded string in a form of "key1=value1|key2=value2|key3=value3". We don't want to append many parameters by using extraUrlParams. We decided then to allow user to define extraparams variable.
avimehta
approved these changes
Dec 16, 2016
rpominov
pushed a commit
to yandex-pcode/amphtml
that referenced
this pull request
Jan 20, 2017
* master: (310 commits) Update csa.md to remove non-required parameters (ampproject#6902) Add notes about requesting ads ATF and link to demo (ampproject#7037) Remove whitelist for lightbox scrollable validator (ampproject#7034) Delegate submit events until amp-form is loaded (ampproject#6929) Moves closure sha384 into a new extension amp-crypto-polyfill for lazy load (ampproject#7006) Refactor observables in viewer-impl into a map object (ampproject#7004) resizing of margins (ampproject#6824) Use URL replacer from embed for pixel (ampproject#7029) adds support for Gemius analytics (ampproject#6558) Avoid duplicating server-layout (ampproject#7021) Laterpay validator config (ampproject#6974) Validator rollup (ampproject#7023) skeleton for amp-tabs (ampproject#7003) Upgrade post-css and related packages to latest (ampproject#7020) handle unload (ampproject#7001) viewer-integr.js -> amp-viewer-integration (ampproject#6989) dev().info()->dev().fine() (ampproject#7017) Turned on experiment flag (ampproject#6774) Unlaunch ios-embed-wrapper for iOS8 to avoid scroll freezing issues (ampproject#7018) Add some A4A ad request parameters (ampproject#6643) ...
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
This was referenced May 2, 2021
This was referenced May 22, 2021
This was referenced Jun 2, 2021
This was referenced Jun 16, 2021
This was referenced Aug 23, 2023
This was referenced Sep 9, 2023
This was referenced Sep 16, 2023
This was referenced Sep 24, 2023
This was referenced Oct 10, 2023
This was referenced Oct 19, 2023
This was referenced Oct 26, 2023
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent to implement: #6556
Closes #6556