Added initial version of amp-anlaytics variable filters. #6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avimehta
force-pushed
the
revert-6542-revert-5621-filters
branch
from
e4badf3
to
51e9f0e
Compare
jridgewell
approved these changes
Dec 8, 2016
| @@ -46,6 +46,8 @@ variableServiceFor(AMP.win); | |||
|
|
|||
| const MAX_REPLACES = 16; // The maximum number of entries in a extraUrlParamsReplaceMap | |||
|
|
|||
| const hasOwn = Object.prototype.hasOwnProperty; | |||
There was a problem hiding this comment.
Might be useful as a utility in /utils/object.js?
|
Yes. Following up on this. Given the large scale changes in this code and the fact that I am going to be ooo next few weeks, I'll submit this in Jan. I'll try and send out a PR to create a function in object.js tomorrow but the other filter changes will go in in Jan. |
|
👍 |
avimehta
added a commit
to avimehta/amphtml
that referenced
this pull request
Dec 9, 2016
Branched from ampproject#6560
Merged
jridgewell
pushed a commit
that referenced
this pull request
Dec 12, 2016
* Added hasOwn helper. Branched from #6560 * Review feedback.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Added hasOwn helper. Branched from ampproject#6560 * Review feedback.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Added hasOwn helper. Branched from ampproject#6560 * Review feedback.
avimehta
force-pushed
the
revert-6542-revert-5621-filters
branch
2 times, most recently
from
d5340e2
to
1f7f437
Compare
avimehta
force-pushed
the
revert-6542-revert-5621-filters
branch
from
1f7f437
to
61ee6ca
Compare
avimehta
changed the title
|
@jridgewell PTAL. |
jridgewell
approved these changes
Jan 6, 2017
| s.push(`${encodeURIComponent(k)}=${sv}`); | ||
| } | ||
| } | ||
|
|
||
| const paramString = s.join('&'); | ||
| const paramString = s.length > 0 ? s.join('&') : ''; |
There was a problem hiding this comment.
The ternary is unnecessary.
3 tasks
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5621.