Forbid assignments inside a conditional #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might fix ampproject#7476. Still investigating. Either way, this is a bug.
|
Yeah, good find. I can't see how this may cause the bug, but it might totally break other things! |
dvoytenko
approved these changes
Feb 10, 2017
dvoytenko
pushed a commit
that referenced
this pull request
Feb 10, 2017
Might fix #7476. Still investigating. Either way, this is a bug.
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
Might fix ampproject#7476. Still investigating. Either way, this is a bug.
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Might fix ampproject#7476. Still investigating. Either way, this is a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix #7476. Still investigating. Either way, this is a bug.