Update a4a-readme.md #7987
Merged
Update a4a-readme.md #7987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dknecht
reviewed
Mar 6, 2017
ads/google/a4a/docs/a4a-readme.md
Outdated
| The following adservers support serving AMP ads at the moment: | ||
| 1. DoubleClick for Publishers | ||
| 2. TripleLift | ||
|
|
keithwrightbos
approved these changes
Mar 6, 2017
ads/google/a4a/docs/a4a-readme.md
Outdated
| @@ -28,21 +28,26 @@ AMP ads are designed to work on both AMP and Non-AMP webpages, including deskto | |||
|
|
|||
| # Current status | |||
|
|
|||
| The AMP ads format spec has been [released](https://github.com/google/amphtml/blob/master/extensions/amp-a4a/amp-a4a-format.md) and any creative developer can create AMP ads. In order for ads to get preferred treatment on AMP pages, ad server support is required. Advertisers using DoubleClick or AdSense can already deliverprogrammatic AMP ads to publisher AMP pages. Publishers using DFP (DoubleClick for Publishers) can already deliver their own AMP ads. Advertisers or publishers using other ad providers can implement AMP ads with the help of a signing service like CloudFlare. Cloudflare provides AMP ad verification services, enabling any independent ad provider to deliver faster, lighter, and more engaging ads. | |||
| The AMP ads format spec has been [released](https://github.com/google/amphtml/blob/master/extensions/amp-a4a/amp-a4a-format.md) and any creative developer can create AMP ads.A number of ad providers are working on automatically converting ads to AMP ads whenever possible. e.g. Adsense | |||
There was a problem hiding this comment.
Add spaces between "create AMP ads." and "A number". Also I believe the S is capitalized in AdSense
There was a problem hiding this comment.
and "." needed after AdSense.
lannka
approved these changes
Mar 6, 2017
ads/google/a4a/docs/a4a-readme.md
Outdated
| @@ -28,21 +28,26 @@ AMP ads are designed to work on both AMP and Non-AMP webpages, including deskto | |||
|
|
|||
| # Current status | |||
|
|
|||
| The AMP ads format spec has been [released](https://github.com/google/amphtml/blob/master/extensions/amp-a4a/amp-a4a-format.md) and any creative developer can create AMP ads. In order for ads to get preferred treatment on AMP pages, ad server support is required. Advertisers using DoubleClick or AdSense can already deliverprogrammatic AMP ads to publisher AMP pages. Publishers using DFP (DoubleClick for Publishers) can already deliver their own AMP ads. Advertisers or publishers using other ad providers can implement AMP ads with the help of a signing service like CloudFlare. Cloudflare provides AMP ad verification services, enabling any independent ad provider to deliver faster, lighter, and more engaging ads. | |||
| The AMP ads format spec has been [released](https://github.com/google/amphtml/blob/master/extensions/amp-a4a/amp-a4a-format.md) and any creative developer can create AMP ads.A number of ad providers are working on automatically converting ads to AMP ads whenever possible. e.g. Adsense | |||
There was a problem hiding this comment.
and "." needed after AdSense.
|
Fixed minor typos. PTAL @lannka |
lannka
approved these changes
Apr 4, 2017
|
I have no idea what the Travis error is about. @erwinmombay do you happen to know? |
|
@rsimha-amp FYI, the same false alarm happened again. Do you think it can be a bug? |
|
@lannka This is likely due to an out-of-date branch. See error message in Travis: "If you see a long list of unrelated files below, you may need to sync your branch to master." Unfortunately, the only fix I'm aware of is to sync the branch to upstream. |
|
seems to be a problem with the diff. we should be doing a 3 parties diffing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifying next steps for A4A interested parties.