-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print a clearer error message when flag-config and non-flag-config files are in the same PR #9166
Print a clearer error message when flag-config and non-flag-config files are in the same PR #9166
Conversation
@lannka / @aghassemi, this should make the failure message less cryptic. Could one of you please merge this after review? (I don't have merge permissions yet.) |
build-system/pr-check.js
Outdated
console.log('Please make your changes in separate pull requests.'); | ||
console.log(util.colors.yellow( | ||
'NOTE: If you see a long list of unrelated files below, it is ' + | ||
'likely because your branch is very old.')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"likely because you need to resync your branch"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned in the next sentence. I've reworded it anyway. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a reminder to remove the second part of the message after a few months.
From time to time, people hit this error because of a really old branch and wonder what this error is all about. Make the error text easier to spot and easier to understand.