Experiment with new ad default placeholder design #8629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
commented
Apr 6, 2017
| .i-amphtml-ad-default-holder[experiment2]:after { | ||
| font-size: 10px; | ||
| line-height: 10px; | ||
| padding: 3px 4px 0px 4px; |
There was a problem hiding this comment.
@spacedino FYI: I changed the padding-left from 3px to 4px. I personally felt different value makes the text not centered. Please let me know if you still think padding-left: 3px is better.
padding-left: 3px
padding-left: 4px
|
ping @alanorozco @spacedino |
alanorozco
approved these changes
Apr 7, 2017
zhouyx
force-pushed
the
new-ad-placeholder-v2
branch
from
2cd2bd8
to
76f2a93
Compare
DarXector
pushed a commit
to DarXector/amphtml
that referenced
this pull request
Apr 25, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8261
Please see #8238 for design detail.
The only change we make is: design version 2, bg color is :
c8c8c8 @ 5%.