Adopt ClickHandler for FIE #8864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Apr 20, 2017
src/url.js
Outdated
| * @param {string} url | ||
| * @return {!Location} | ||
| */ | ||
| export function parseUrlWithA(a, url) { |
There was a problem hiding this comment.
Should we restrict access to this function?
There was a problem hiding this comment.
There's nothing really dangerous about it, is there?
There was a problem hiding this comment.
Not dangerous, but we have a cached anchor in this module to avoid every ole caller making there own. And I'd probably want to review anyone using this to make sure they intend to use a cross-origin anchor element.
There was a problem hiding this comment.
Makes sense. I'll make it restricted then.
jridgewell
approved these changes
Apr 21, 2017
added 2 commits
April 21, 2017 13:08
DarXector
pushed a commit
to DarXector/amphtml
that referenced
this pull request
Apr 25, 2017
* Adopt ClickHandler for FIE * restrict parseUrlWithA * fixed types * whitelist presubmits
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Adopt ClickHandler for FIE * restrict parseUrlWithA * fixed types * whitelist presubmits
KenneyE
pushed a commit
to spotxchange/amphtml
that referenced
this pull request
May 3, 2017
* Adopt ClickHandler for FIE * restrict parseUrlWithA * fixed types * whitelist presubmits
This was referenced Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly straightforward refactoring, but for some reason GitHub doesn't catch the file move and shows 100% diff on
document-click.js:(Closes #6578.