Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt ClickHandler for FIE #8864

Merged
merged 4 commits into from Apr 21, 2017
Merged

Adopt ClickHandler for FIE #8864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39372de
Adopt ClickHandler for FIE
Apr 12, 2017
1405de5
restrict parseUrlWithA
Apr 21, 2017
cd798b2
fixed types
Apr 21, 2017
dfebe7d
whitelist presubmits
Apr 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions build-system/tasks/presubmit-checks.js
View file
Open in desktop
Expand Up @@ -283,6 +283,14 @@ var forbiddenTerms = {
'tools/experiments/experiments.js',
],
},
'parseUrlWithA': {
message: 'Use parseUrl instead.',
whitelist: [
'src/url.js',
'src/service/document-click.js',
'dist.3p/current/integration.js',
],
},
'\\.sendMessage\\(': {
message: 'Usages must be reviewed.',
whitelist: [
Expand Down
2 changes: 0 additions & 2 deletions src/amp.js
View file
Open in desktop
Expand Up @@ -27,7 +27,6 @@ import {
performanceFor,
} from './service/performance-impl';
import {installPullToRefreshBlocker} from './pull-to-refresh';
import {installGlobalClickListenerForDoc} from './document-click';
import {installStyles, makeBodyVisible} from './style-installer';
import {installErrorReporting} from './error';
import {installDocService} from './service/ampdoc-impl';
Expand Down Expand Up @@ -97,7 +96,6 @@ startupChunk(self.document, function initial() {
});
startupChunk(self.document, function final() {
installPullToRefreshBlocker(self);
installGlobalClickListenerForDoc(ampdoc);

maybeValidate(self);
makeBodyVisible(self.document, /* waitForServices */ true);
Expand Down
258 changes: 0 additions & 258 deletions src/document-click.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/inabox/amp-inabox.js
View file
Open in desktop
Expand Up @@ -28,7 +28,6 @@ import {
performanceFor,
} from '../service/performance-impl';
import {installPullToRefreshBlocker} from '../pull-to-refresh';
import {installGlobalClickListenerForDoc} from '../document-click';
import {installStyles, makeBodyVisible} from '../style-installer';
import {installErrorReporting} from '../error';
import {installDocService} from '../service/ampdoc-impl';
Expand Down Expand Up @@ -111,7 +110,6 @@ startupChunk(self.document, function initial() {
});
startupChunk(self.document, function final() {
installPullToRefreshBlocker(self);
installGlobalClickListenerForDoc(ampdoc);
installAnchorClickInterceptor(ampdoc, self);

maybeValidate(self);
Expand Down
2 changes: 2 additions & 0 deletions src/runtime.js
View file
Open in desktop
Expand Up @@ -51,6 +51,7 @@ import {
import {installActionServiceForDoc} from './service/action-impl';
import {installCryptoService} from './service/crypto-impl';
import {installDocumentInfoServiceForDoc} from './service/document-info-impl';
import {installGlobalClickListenerForDoc} from './service/document-click';
import {installGlobalSubmitListenerForDoc} from './document-submit';
import {extensionsFor} from './services';
import {installHistoryServiceForDoc} from './service/history-impl';
Expand Down Expand Up @@ -145,6 +146,7 @@ export function installAmpdocServices(ampdoc, opt_initParams) {
installActionServiceForDoc(ampdoc);
installStandardActionsForDoc(ampdoc);
installStorageServiceForDoc(ampdoc);
installGlobalClickListenerForDoc(ampdoc);
installGlobalSubmitListenerForDoc(ampdoc);
}

Expand Down