Add support for change events on <select> elements
#8943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/service/action-impl.js
Outdated
| @@ -216,6 +216,9 @@ export class ActionService { | |||
| }); | |||
| event.detail = detail; | |||
| } | |||
| } else if (event.target.tagName.toLowerCase() === 'select') { | |||
There was a problem hiding this comment.
Recommend moving LHS to a local tagName var and use a switch statement.
dreamofabear
approved these changes
Apr 25, 2017
src/service/action-impl.js
Outdated
| detail[field] = String(value); | ||
| } | ||
| }); | ||
| const tagName = event.target.tagName.toLowerCase(); |
There was a problem hiding this comment.
Nit: target instead of event.target.
src/service/action-impl.js
Outdated
| } | ||
| break; | ||
| case 'select': | ||
| detail['value'] = target['value']; |
src/service/action-impl.js
Outdated
| @@ -199,23 +199,30 @@ export class ActionService { | |||
| addChangeDetails_(event) { | |||
| const detail = {}; | |||
src/service/action-impl.js
Outdated
| detail[field] = String(value); | ||
| } | ||
| }); | ||
| event.detail = detail; |
There was a problem hiding this comment.
Probably can take this out of the switch to reduce dupe.
There was a problem hiding this comment.
ok, but we should only set this if detail isn't empty
kmh287
force-pushed
the
select_change_event
branch
from
15e6d28
to
030316e
Compare
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
KenneyE
pushed a commit
to spotxchange/amphtml
that referenced
this pull request
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just expands on the work done to support
inputelements.Fixes #8939