Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use describes for form validator tests. #9105

Merged
merged 1 commit into from
May 2, 2017
Merged

Use describes for form validator tests. #9105

merged 1 commit into from
May 2, 2017

Conversation

cvializ
Copy link
Contributor

@cvializ cvializ commented May 2, 2017

I broke this out from #9054 to clean up the diff, sorry about the rebase there.

@jridgewell
Copy link
Contributor

https://github.com/ampproject/amphtml/pull/9105/files?w=1

@cvializ
Copy link
Contributor Author

cvializ commented May 2, 2017

I don't understand what you mean by linking to the files page. Could you please explain?

@jridgewell
Copy link
Contributor

The ?w=1 strips whitespace when reviewing (but you won't be able to leave comments). Just makes it easier to review.

@cvializ
Copy link
Contributor Author

cvializ commented May 2, 2017

Oh I see, thanks.

I still don't have merge permission, so feel free to merge any time.

@jridgewell jridgewell merged commit 2d54582 into ampproject:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@aghassemi aghassemi Awaiting requested review from aghassemi

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cvializ @jridgewell @googlebot @ampprojectbot