Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Remove includeOnlyESMLevelPolyfills #30630

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

jridgewell
Copy link
Contributor

All polyfills are already guarded by IS_ESM and IS_SXG checks already, so an additional build-time removal is not necessary anymore.

@amp-owners-bot
Copy link

Hey @rsimha! These files were changed:

build-system/compile/compile.js

These are guarded by `IS_ESM` and `IS_SXG` checks already, so an additional build-time removal is not necessary anymore.
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

@kristoferbaxter kristoferbaxter merged commit 1507daf into ampproject:master Oct 12, 2020
@jridgewell jridgewell deleted the esm-polyfills-2 branch October 12, 2020 22:14
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
These are guarded by `IS_ESM` and `IS_SXG` checks already, so an additional build-time removal is not necessary anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants