fix: bw-incompatible update to user elasticsearch index #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2021 12:35
Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com>
Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com>
dkunitsk
requested review from
allisonsuarez,
bolkedebruin,
dorianj,
feng-tao,
jinhyukchang,
mgorsk1,
verdan and
a team
as code owners
amommendes
pushed a commit
to amommendes/amundsen
that referenced
this pull request
Jul 22, 2021
…1241) * fix: update user elasticsearch index Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * bump version Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> Signed-off-by: Amom <amommendes@hotmail.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
…1241) * fix: update user elasticsearch index Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * bump version Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
…1241) * fix: update user elasticsearch index Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * bump version Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitriy Kunitskiy dkunitskiy@lyft.com
Summary of Changes
This change fixes the discrepancy between the user ES index located in common vs databuilder. The discrepancy is in one field:
full_namevsname.This is being done in preparation for deleting the
elasticsearch_constants.pydatabuilder file and importing these mappings from common instead.The same cleanup was performed here but had to be reverted because of some marshmallow thing that's no longer relevant.
Why this change is safe-ish:
full_name.full_name: model, proxyamundsen-common's index is here in the ES proxy. This function is only used to create an index when an index is not found. But the ES publisher does create an index as its first step so in theory this function should be mostly unused.In other words, data should be loaded using
full_nameand searched usingfull_name. The fact that an index exists in another place withnameinstead offull_namejust means people who've been using it were probably having semi-broken user search.Notice to community
Backwards incompatible change alert!
We're deleting databuilder's elasticsearch_constants.py file in favor of amundsen-common's index_map.py. If you were using databuilder's constants, please switch to common.