Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "refactor: Update ES index maps to use same maps of amundsen-common" #389

Merged
merged 1 commit into from Oct 20, 2020
Merged

fix: Revert "refactor: Update ES index maps to use same maps of amundsen-common" #389

merged 1 commit into from Oct 20, 2020

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Oct 20, 2020 •
edited

Reverts #385

Reverting because marshmallow >v3.0 is not compatible with marshmallow-annotations, will deprecate annotations dep to fix.

@feng-tao
Copy link
Member

DCO fails

feng-tao
feng-tao approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would be good to let the original contributor know the context.

@allisonsuarez
Revert "refactor: Update ES index maps to use same maps of amundsen-c…
ddaac21 
…ommon (#385)"

This reverts commit 20c2fd2.

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez force-pushed the revert-385-import_amundsen_common branch from 960db70 to ddaac21 Compare October 20, 2020 01:03
@allisonsuarez
Copy link
Contributor Author

allisonsuarez commented Oct 20, 2020 •
edited

@Wonong Hey! just wanted to let you know that we decided to temporarily revert these changes because marshmallow >v3.0 is not compatible with marshmallow-annotations on amundsen-common, and since annotations dependency is not regularly maintained we will work on getting rid of it altogether.

@allisonsuarez allisonsuarez merged commit 2870387 into master Oct 20, 2020
@allisonsuarez allisonsuarez deleted the revert-385-import_amundsen_common branch October 20, 2020 01:09
@Wonong
Copy link
Contributor

Wonong commented Oct 20, 2020

Thanks for your mention :)

@dkunitsk dkunitsk mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feng-tao feng-tao feng-tao approved these changes

@dikshathakur3119 dikshathakur3119 Awaiting requested review from dikshathakur3119 dikshathakur3119 is a code owner

@jinhyukchang jinhyukchang Awaiting requested review from jinhyukchang jinhyukchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@allisonsuarez @feng-tao @Wonong