Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update ES index maps to use same maps of amundsen-common #385

Merged
merged 6 commits into from Oct 16, 2020

Conversation

Wonong
Copy link
Contributor

@Wonong Wonong commented Oct 16, 2020

Summary of Changes

  • Added amundsen-common package to requirements.txt
  • Deleted python 2.7 in extras_require in setup.py since python_requires only allow python versions higher than 3.6
  • Deleted elasticsearch_constants.py and updated related codes to use ES index map of amundsen-common

Tests

Execute sample_data_loader following this guide(https://github.com/amundsen-io/amundsen/blob/master/docs/installation.md#bootstrap-a-default-version-of-amundsen-using-docker)
and it works successfully

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
…undsendatabuilder into import_amundsen_common

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
@Wonong Wonong closed this Oct 16, 2020
@Wonong Wonong reopened this Oct 16, 2020
Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@feng-tao feng-tao merged commit 20c2fd2 into amundsen-io:master Oct 16, 2020
allisonsuarez added a commit that referenced this pull request Oct 20, 2020
allisonsuarez added a commit that referenced this pull request Oct 20, 2020
…ommon (#385)"

This reverts commit 20c2fd2.

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez added a commit that referenced this pull request Oct 20, 2020
…ommon (#385)" (#389)

This reverts commit 20c2fd2.

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants