Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Rebound API integration (Rebound 3.2.3) #109

Closed
rieder opened this issue Mar 16, 2017 · 5 comments
Closed

Complete Rebound API integration (Rebound 3.2.3) #109

rieder opened this issue Mar 16, 2017 · 5 comments
Assignees

Comments

@rieder
Copy link
Member

rieder commented Mar 16, 2017

Some settable parameters of Rebound are still missing from the interface, including some important ones (symplectic correctors for WHFast/WHFasthelio, accuracy for IAS15, switching radius between ias15/whfast for Helios, etc). I'd like to implement these.
However, I'm wondering how to go about doing this. Of course I can add them as parameters to the interface (doing this now, work in progress), but some parameters may not be settable unless a specific integrator is chosen. So there would need to be a specific order in setting these parameters. Or would there be a better way of doing this?
cc @arjenve

@ipelupessy
Copy link
Member

the way to do this I think, is to have a temporary interface parameter, and set the parameters at commit_parameters and recommit_parameters (if necessary)

@rieder
Copy link
Member Author

rieder commented Mar 19, 2017

Ok, thanks, I'll try that.

@rieder rieder self-assigned this Mar 31, 2017
@ipelupessy
Copy link
Member

can this be closed?

@rieder
Copy link
Member Author

rieder commented Jul 5, 2017 via email

@rieder
Copy link
Member Author

rieder commented Oct 8, 2018

Reminder that I should spend a day on this

@rieder rieder closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants