Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari (Windows) not loading completely #195

Closed
mjslee opened this issue Mar 15, 2011 · 8 comments
Closed

Safari (Windows) not loading completely #195

mjslee opened this issue Mar 15, 2011 · 8 comments

Comments

@mjslee
Copy link
Collaborator

mjslee commented Mar 15, 2011

We discussed this briefly and thought one solution would be implementing a time-out for loading. However, this might mean that they won't see the intro, or play the game without any sounds.

Observations:

  1. Hangs on "1 remaining to download" and doesn't go any further.
  2. Intro movie never shows, but force-playing it using the debug menu suggest that all image files are being loaded correctly.
  3. Not loading any sounds resolves both problems 1 and 2, but results in no sound effects.
@mjslee
Copy link
Collaborator Author

mjslee commented Mar 15, 2011

If we end up not supporting Windows Safari, we need to uncomment initialize.js:103 so that it will be added to the unsupported browser/os list.

@amyjko
Copy link
Owner

amyjko commented Mar 15, 2011

I'll try to diagnose this today after my Windows 7 install finishes updating. I've waited 2.5 hours now...

@mjslee
Copy link
Collaborator Author

mjslee commented Mar 15, 2011

Wow. that's a very long time!

@amyjko
Copy link
Owner

amyjko commented Mar 15, 2011

I can't reproduce this on a fresh install of Safari 5. It successfully loads. I've heard that the tag doesn't work if Quicktime isn't installed. Perhaps that's the cause?

@mjslee
Copy link
Collaborator Author

mjslee commented Mar 15, 2011

I do not have quicktime installed, so that is probably the culprit. How shall we handle this situation?

According to stackoverflow, this javascript code can detect if quicktime is installed:
var QtPlugin = navigator.plugins["Quicktime"];
if (QtPlugin) {//QuickTime is installed}

If it quicktime isn't installed and they are using Safari, should we politely tell them to install it or use another browser to continue?

@amyjko
Copy link
Owner

amyjko commented Mar 15, 2011

This seems like a good solution. Can you add it as part of your browser check in initialize.js?

@mjslee
Copy link
Collaborator Author

mjslee commented Mar 15, 2011

Yes, I'll take this ticket over.
Sorry about all the issues that turned out not to be bugs! :(

I'm going to install Linux on Parallels since it's a good idea to test to make sure everything works on a fresh install (of browsers).

@mjslee
Copy link
Collaborator Author

mjslee commented Mar 16, 2011

I tried several quicktime detectors in Javascript (including the one referenced above) and found that there was no consistency across browsers. Most of the scripts have a dependency on Netscape plugin architecture or MSIE ActiveX architecture to work correctly, which the WebKit and Safari browsers don't support.

Since the number of Windows Safari users will be slim, I'm currently taking it off the whitelist until a better, more consistent script that doesn't mess up Gidget is working and tested.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants