AppVeyor: Fix creation of symblic links for good #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main repository contains symbolic links to directories in the submodule. As the submodule is initialized after the main repository, it is unknown to Git whether the links point to files or directories. On Windows, this is important to know as symbolic links can point to either files or directories, and the type has to be known at the point of their creation. The default is to create file symbolic links, which is wrong in this case. So delete the symbolic links and check them out again after the submodule has been initialized to get them recreated as directory symbolic links.
|
Cool -- looks like AppVeyor is reporting a successful status here too. Thanks for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The main repository contains symbolic links to directories in the
submodule. As the submodule is initialized after the main repository, it
is unknown to Git whether the links point to files or directories. On
Windows, this is important to know as symbolic links can point to
either files or directories, and the type has to be known at the point of
their creation. The default is to create file symbolic links, which is
wrong in this case. So delete the symbolic links and check them out
again after the submodule has been initialized to get them recreated as
directory symbolic links.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.