Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #292: bad alloc performance due to excessive memset #293

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

m6w6
Copy link
Contributor

@m6w6 m6w6 commented Apr 5, 2022

Issue #, if available: #292

Description of changes:

  • remove memset in _ion_alloc_with_owner_helper
  • fix crashes and failing tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @m6w6 !

@tgregg tgregg merged commit 1c57bf9 into amazon-ion:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants