Fix leak of resources when unable to flush binary writer #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit when a binary writer was closed, but could not be flushed, the _ion_writer_close_helper function would skip _ion_writer_binary_close, which resulted in the binary writer's _value_stream being leaked. This commit updates the close functions for both binary and text formats to include a BOOL to communicate if we want to flush or not. _ion_writer_close_helper was then updated to track if we are able to flush and provide that info to the format writer's close, so we can ensure all resources are cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
Prior to this commit when a binary writer was closed,
but could not be flushed, the
_ion_writer_close_helperfunction would skip
_ion_writer_binary_close, whichresulted in the binary writer's
_value_streambeingleaked.
This commit updates the close functions for both binary
and text formats to include a BOOL to communicate if
we want to flush or not.
_ion_writer_close_helperwas thenupdated to track if we are able to flush and provide
that info to the format writer's close, so we can ensure
all resources are cleaned up.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.