fix: types for FormatHelpers.LineFormatting to add commentPosition #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenbroekema
force-pushed
the
release-3.9.1
branch
from
04ac854
to
52031b3
Compare
jorenbroekema
force-pushed
the
release-3.9.1
branch
from
52031b3
to
fcce1d4
Compare
dbanksdesign
approved these changes
Nov 27, 2023
This was referenced Dec 7, 2023
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#953 (comment)
Description of changes:
Adds commentPosition prop to FormatHelpers.LineFormatting type
We should release 3.9.1 as well, for a fix in outputReferences (falsy values not replaced atm)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.