-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: account for multi-line comments in tokens, improve comment style #953
Conversation
I added a second commit with a small change that allows formatting prop to be user-passed, even if the format is css/sass/less/stylus, as well as a small change to allow passing commentStyle "short-above" or "long-above" to ensure the comment is put 1 line above the outputted property, rather then inline next to it. Let me know if those two things are okay or you prefer it some other way or via a separate PR |
9bd08f6
to
eea72f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just a few minor things! Thank you!
eea72f7
to
6bf26bc
Compare
7bc1363
to
b71063f
Compare
b71063f
to
b9270b2
Compare
Should this have documentation updated as well around the additional options for https://amzn.github.io/style-dictionary/#/formats?id=fileheader Related, are these types incorrect? The types listed here say the options for style-dictionary/types/FormatHelpers.d.ts Line 21 in 0272b8f
|
Good catch, thanks: #1047 |
Issue #, if available:
fixes #952
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.