Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(example): fixing font-face example #824

Merged
merged 1 commit into from
Jun 2, 2022
Merged

chore(example): fixing font-face example #824

merged 1 commit into from
Jun 2, 2022

Conversation

dbanksdesign
Copy link
Member

Issue #, if available:

Description of changes:

  • Updating the font-face-rules example to put 'style-dictionary' in the devDependencies rather than the dependencies
  • Updating the version script to be more resilient and not totally fail in cases like this.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

chazzmoney
chazzmoney approved these changes Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@chazzmoney chazzmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dbanksdesign dbanksdesign merged commit f5b7bb5 into main Jun 2, 2022
@dbanksdesign dbanksdesign deleted the fix-version branch June 2, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chazzmoney chazzmoney chazzmoney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbanksdesign @chazzmoney