Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update JSDoc param names to match argument names #939

Conversation

jessicalynch
Copy link
Contributor

#281

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jessicalynch jessicalynch changed the title Update JSDoc param names to match argument names docs: update JSDoc param names to match argument names Feb 25, 2023
@dbanksdesign dbanksdesign marked this pull request as ready for review March 16, 2023 21:55
Copy link
Collaborator

@chazzmoney chazzmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! :shipit:

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing the broken tests too!

@dbanksdesign dbanksdesign merged commit e7800b9 into amzn:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants