Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic TDD Engine #975

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Generic TDD Engine #975

merged 5 commits into from
Dec 13, 2022

Conversation

podgori
Copy link
Contributor

@podgori podgori commented Jul 26, 2022

Replaces the existing axi_tdd with the new version

@podgori podgori requested a review from a team July 26, 2022 13:45
@IuliaCMoldovan
Copy link
Contributor

The Guideline checker action for this PR will fail because SystemVerilog files are not fully supported, for example packages.

Copy link
Contributor

@ronagyl ronagyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IP looks great, however since it is not pin compatible with the old IP the project which use is will fail. Example projects/ad9081_fmca_ebz/zcu102 when compiled with the following parameters:

make TDD_SUPPORT=1 SHARED_DEVCLK=1

Ideally this commit should go to master only when the above project is updated.

@podgori
Copy link
Contributor Author

podgori commented Aug 17, 2022

v1.1: Minor update in axi_tdd_channel.sv to change the reset value of ch_pol to DEFAULT_POLARITY.

@podgori
Copy link
Contributor Author

podgori commented Oct 6, 2022

V2

  • Removed tdd_active output
  • Replaced .xdc constraints file with .ttcl constraint generating file
  • Fixed ch_pol to reset to DEFAULT_POLARITY
  • Renamed CDC sync flops for ext sync signal

@podgori
Copy link
Contributor Author

podgori commented Oct 11, 2022

v2.1: Added the TDD regmap files.

@podgori
Copy link
Contributor Author

podgori commented Nov 21, 2022

v2.2: Integrated the new TDD engine in the ad9081_fmca_ebz_x_band project.

FilipG24
FilipG24 previously approved these changes Nov 22, 2022
Copy link
Contributor

@FilipG24 FilipG24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@podgori
Copy link
Contributor Author

podgori commented Dec 6, 2022

v2.3: Updated the scripts to create a wrapper around the TDD core and generated channel slices.

acostina
acostina previously approved these changes Dec 12, 2022
Signed-off-by: Ionut Podgoreanu <ionut.podgoreanu@analog.com>
Replaced the existing axi_tdd with the new version
* Added DEFAULT_POLARITY synth parameter and RO register
* Added TDD_STATUS register
* Added TDD_SYNC_RST feature
* Used the asy_ prefix for signals which are not synced
* Added logic to force the state from ARMED to RUNNING when startup_delay=0
* Added feature to finish the burst when the module is disabled before its completion

Signed-off-by: Ionut Podgoreanu <ionut.podgoreanu@analog.com>
@podgori podgori merged commit b3f3f7c into master Dec 13, 2022
@podgori podgori deleted the dev_tdd_pr branch December 13, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants