-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move nitro integration into separate vite plugin package #341
Conversation
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yarn command fails to run due to nrwl/nx#15263. deactivating tests for now until workaround is found.
@brandonroberts I cannot get the e2e tests for the plugin to pass... I think it is due to nrwl/nx#15263. If you have time to take a look at this that would be awesome. I am a little bit at my wits end because I see other PRs pass 😭 I disabled them for now just to see if everything else works fine |
@goetzrobin no problem. Seeing as how all the other tests pass the preview builds are working, I think its good to go. Maybe it will be resolved when we publish the package. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Currently the platform package includes a plugin that enables nitro support for development and production.
The idea is to move this plugin into its own package and ultimately allow users to pick a backend of their choice.
Issue Number: #318
What is the new behavior?
nitro integration is moved to a separate package
Does this PR introduce a breaking change?
Not the way it is implemented right now. We are making the platform package depend on the new nitro package and include the nitro plugin as part of the platform plugin array
Other information
Open questions:
Let me know what you think!