Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move nitro integration into separate vite plugin package #341

Merged
merged 6 commits into from
Apr 15, 2023

Conversation

goetzrobin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router
  • platform
  • content

What is the current behavior?

Currently the platform package includes a plugin that enables nitro support for development and production.
The idea is to move this plugin into its own package and ultimately allow users to pick a backend of their choice.

Issue Number: #318

What is the new behavior?

nitro integration is moved to a separate package

Does this PR introduce a breaking change?

  • Yes
  • No

Not the way it is implemented right now. We are making the platform package depend on the new nitro package and include the nitro plugin as part of the platform plugin array

Other information

Open questions:

  • do we want to share the Options/PrerenderOptions interfaces and move them in a separate package? Currently, I just copied and pasted them to get started...
  • do we want to include the nitro plugin by default or leave it up to the user?
  • do we want to remove analog references in the nitro plugin, e.g. build output folder is analog currently?

Let me know what you think!

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 154f2f2
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64396c25af4e43000846e028
😎 Deploy Preview https://deploy-preview-341--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 154f2f2
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64396c26552dc9000743f81a
😎 Deploy Preview https://deploy-preview-341--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 154f2f2
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64396c2666d10e000884d876
😎 Deploy Preview https://deploy-preview-341--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@goetzrobin
Copy link
Member Author

goetzrobin commented Apr 14, 2023

@brandonroberts I cannot get the e2e tests for the plugin to pass... I think it is due to nrwl/nx#15263. If you have time to take a look at this that would be awesome. I am a little bit at my wits end because I see other PRs pass 😭 I disabled them for now just to see if everything else works fine

@brandonroberts
Copy link
Member

@goetzrobin no problem. Seeing as how all the other tests pass the preview builds are working, I think its good to go. Maybe it will be resolved when we publish the package.

@goetzrobin goetzrobin marked this pull request as ready for review April 14, 2023 17:53
@brandonroberts brandonroberts merged commit aeea815 into main Apr 15, 2023
@brandonroberts brandonroberts deleted the extract-vite-plugin-nitro branch April 15, 2023 23:20
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants